Skip to content

Fix aliasing issues#112

Open
456263 wants to merge 2 commits intoagrimgupta92:masterfrom
456263:master
Open

Fix aliasing issues#112
456263 wants to merge 2 commits intoagrimgupta92:masterfrom
456263:master

Conversation

@456263
Copy link
Copy Markdown

@456263 456263 commented Apr 17, 2022

This pull requests addresses incorrect validation loss calculation and checkpoint saving behavior due to unintentional aliasing.
Specifically:

  • the lists used to calculate the validation metrics referred to the same object, per line of declaration;
  • the saved states corresponding to the best/last models coincided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant